Add AdditionalRuntimeIdentifier if building from source #34650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
mthalman
approved these changes
Aug 16, 2023
Member
|
This needs to be backported to the rc1 branch. |
Member
This also needs to be backported to the |
MichaelSimons
approved these changes
Aug 16, 2023
dsplaisted
approved these changes
Aug 16, 2023
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
Looks good. As mentioned, it will need to be backported to 8.0.1xx and 8.0.1xx-rc1.
Once this is merged we should validate that the portable RID graph is correct for a source build.
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify RID to add to graph per mechanism in #34279
This needs dotnet/installer#17197 to actually work (
TargetRidis currently not set).Fixes dotnet/source-build#3584
cc @tmds @dotnet/source-build-internal